Drop @lends tags during membership inference (fixes #161) #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
161-spurious-lends
branch
from
dd82721 to
44e0303
Compare
Member
|
👍 note: as coveralls hints, it looks like there isn't a testcase that hits the comment.lends line |
Member
Author
|
Oops, that's dead code now. Will remove. |
jfirebaugh
force-pushed
the
161-spurious-lends
branch
from
44e0303 to
9dcfa84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Membership inference used to drop @lends tags as a side effect. Now they make it through the whole chain and produce output even though they aren't meaningful in that way.
This restores the pre-unstream behavior by allowing function elements in the comment pipeline to return undefined to eliminate that comment from further processing.
👀 @tmcw