allowing multiple --externs options to be passed #11

Merged
merged 1 commit into from May 25, 2011

Projects

None yet

2 participants

@xiazek

As initializer takes hash, it was not possible to pass multiple attributes of the same kind.
I made it possible to pass an array of --extern (or other attributes). See comments of commit on Github.

@xiazek

Google closure allows to add multiple --externs options like below
"--externs library1.js --externs library2.js"

Till now constructor was receiving options as a hash which was not allowing to pass multiple attributes of the same kind ({:externs => "library1", :externs => "library2"}).

I made a changes allowing to pass an array of such attributes. For example:
{:externs => ["library1.js", "library2.js"]
which produces :

"--externs library1.js --externs library2.js"

as options

@jashkenas jashkenas merged commit 0243477 into documentcloud:master May 25, 2011
@jashkenas
DocumentCloud member

Looks good -- thanks.

@xiazek

at your services ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment