New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ECMAScript 5 by default #21

Merged
merged 1 commit into from Dec 11, 2012

Conversation

Projects
None yet
4 participants
@rykov
Contributor

rykov commented Jun 6, 2012

All modern browsers use ES5 as their standard, and it often causes confusion when Javascript files fail to compress, but work in the browser. I often run into this roadblock when using the Rails Asset Pipeline in development mode (no compression) vs precompiling (with compression).

This change makes ES5 the default compression.

@doxavore

This comment has been minimized.

doxavore commented Dec 10, 2012

👍 This would be a nice thing to merge.

@rykov

This comment has been minimized.

Contributor

rykov commented Dec 10, 2012

I just got bit by this again as well. Please merge or advise

@jashkenas

This comment has been minimized.

Member

jashkenas commented Dec 11, 2012

Will do -- but before I do ... what exactly is the change that this makes? Also, if you rebase it, I can merge cleanly.

@caseywebdev

This comment has been minimized.

Member

caseywebdev commented Dec 11, 2012

Stuff like

var arr = [1, 2,];
var obj = {a: 1, b: 2,};

will not compile without setting language/language_in to ECMASCRIPT5. This is annoying for third party scripts that have trailing commas. Other nuances too probably...

@rykov

This comment has been minimized.

Contributor

rykov commented Dec 11, 2012

My issue is hard errors on terms that were reserved in EMCA 3 (the current default), but released in EMCA 5. Ember.js uses volatile as a function name, which works fine in all browsers but causes errors in closure-compiler

@jashkenas

This comment has been minimized.

Member

jashkenas commented Dec 11, 2012

Mind rebasing so I can merge cleanly?

@rykov

This comment has been minimized.

Contributor

rykov commented Dec 11, 2012

Putting it together now

On Tue, Dec 11, 2012 at 10:20 AM, Jeremy Ashkenas
notifications@github.comwrote:

Mind rebasing so I can merge cleanly?


Reply to this email directly or view it on GitHubhttps://github.com//pull/21#issuecomment-11255462.

@rykov

This comment has been minimized.

Contributor

rykov commented Dec 11, 2012

Ok - it's ready.

jashkenas added a commit that referenced this pull request Dec 11, 2012

Merge pull request #21 from rykov/es5
Use ECMAScript 5 by default

@jashkenas jashkenas merged commit 735a206 into documentcloud:master Dec 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment