New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict between _.partition in Underscore and contrib #115

Closed
joshuacc opened this Issue Feb 3, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@joshuacc
Contributor

joshuacc commented Feb 3, 2014

Underscore recently added a partition method which conflicts with the one in contrib. jashkenas/underscore#1430

I haven't had a chance to look into it very much, but we should figure out a way to resolve the conflict.

@locks

This comment has been minimized.

Show comment
Hide comment
@locks

locks Feb 3, 2014

Contributor

While a rename would probably be the easiest way to go about it, I'd just like to note that there is a similarly proposed _.groupsOf, which includes a comment by @fogus himself.

Contributor

locks commented Feb 3, 2014

While a rename would probably be the easiest way to go about it, I'd just like to note that there is a similarly proposed _.groupsOf, which includes a comment by @fogus himself.

@joshuacc

This comment has been minimized.

Show comment
Hide comment
@joshuacc

joshuacc Feb 21, 2014

Contributor

@fogus I'm guessing renaming our current partition is the way to go. Have a preference on a new name so I can get a fix in?

Contributor

joshuacc commented Feb 21, 2014

@fogus I'm guessing renaming our current partition is the way to go. Have a preference on a new name so I can get a fix in?

@joshuacc joshuacc added the bug label Feb 22, 2014

@joshuacc joshuacc closed this in 353f573 Feb 22, 2014

@joshuacc

This comment has been minimized.

Show comment
Hide comment
@joshuacc

joshuacc Feb 22, 2014

Contributor

For now I've gone with _.chunk and _.chunkAll since that seemed the clearest to me when accounting for both methods.

Contributor

joshuacc commented Feb 22, 2014

For now I've gone with _.chunk and _.chunkAll since that seemed the clearest to me when accounting for both methods.

@fogus

This comment has been minimized.

Show comment
Hide comment
@fogus

fogus Feb 23, 2014

Member

I like those names. Thanks Joshua.

On Saturday, February 22, 2014, Joshua Clanton notifications@github.com
wrote:

For now I've gone with _.chunk and _.chunkAll since that seemed the
clearest to me when accounting for both methods.


Reply to this email directly or view it on GitHubhttps://github.com/documentcloud/underscore-contrib/issues/115#issuecomment-35815191
.

-- http://blog.fogus.me

-- http://github.com/fogus

Member

fogus commented Feb 23, 2014

I like those names. Thanks Joshua.

On Saturday, February 22, 2014, Joshua Clanton notifications@github.com
wrote:

For now I've gone with _.chunk and _.chunkAll since that seemed the
clearest to me when accounting for both methods.


Reply to this email directly or view it on GitHubhttps://github.com/documentcloud/underscore-contrib/issues/115#issuecomment-35815191
.

-- http://blog.fogus.me

-- http://github.com/fogus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment