From 1399524cf00c40c401af7ec88af6b062edd26f2a Mon Sep 17 00:00:00 2001 From: annahileta Date: Thu, 16 Nov 2023 13:59:04 +0200 Subject: [PATCH 1/2] fixing issues with unit tests --- .../ExecuteScenarioServiceTests.cs | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/DocuSign.MyAPI.Tests/ExecuteScenarioServiceTests.cs b/DocuSign.MyAPI.Tests/ExecuteScenarioServiceTests.cs index 1fb34d8..14537b7 100644 --- a/DocuSign.MyAPI.Tests/ExecuteScenarioServiceTests.cs +++ b/DocuSign.MyAPI.Tests/ExecuteScenarioServiceTests.cs @@ -43,7 +43,7 @@ public ExecuteScenarioServiceTests() var authResult = AuthenticateResult.Success( new AuthenticationTicket(new ClaimsPrincipal(), "DocuSign")); - authResult.Properties.StoreTokens(new[] + authResult.Properties?.StoreTokens(new[] { new AuthenticationToken { Name = "access_token", Value = "token_123" } }); @@ -694,7 +694,7 @@ public async Task ExecuteScenarioStep_CorrectArgument_ReturnCorrectResponse() new Parameter { RequestParameterPath = "accountId", - Source = null, + Source = string.Empty, In = "Path" } } @@ -706,7 +706,7 @@ public async Task ExecuteScenarioStep_CorrectArgument_ReturnCorrectResponse() var expectedBody = JToken.Parse("{\"name\": \"Vas\", \"email\": \"val2\"}").ToString(); //Act - var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, null); + var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, new StepResponse[]{}, new StepParameters[]{}); //Assert Assert.Equal("https://testApi.com/api/createEntity/accountId123", response.API); @@ -743,7 +743,7 @@ public async Task ExecuteScenarioStep_CorrectArgumentsWithRandomParameter_Return new Parameter { RequestParameterPath = "accountId", - Source = null, + Source = string.Empty, In = "Path" } } @@ -756,7 +756,7 @@ public async Task ExecuteScenarioStep_CorrectArgumentsWithRandomParameter_Return var expectedBody = JToken.Parse("{\"name\": \"User 25 name\", \"email\": \"val2\"}").ToString(); //Act - var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, null); + var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, new StepResponse[]{}, new StepParameters[]{}); //Assert Assert.Equal("https://testApi.com/api/createEntity/accountId123", response.API); @@ -793,7 +793,7 @@ public async Task ExecuteScenarioStep_InvalidParametersPrompt_Skips_ReturnsCorre new Parameter { RequestParameterPath = "accountId", - Source = null, + Source = string.Empty, In = "Path" } } @@ -805,7 +805,7 @@ public async Task ExecuteScenarioStep_InvalidParametersPrompt_Skips_ReturnsCorre var expectedBody = JToken.Parse("{\"name\": \"[name]\", \"email\": \"val2\"}").ToString(); //Act - var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, null); + var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, new StepResponse[]{}, new StepParameters[]{}); //Assert Assert.Equal("https://testApi.com/api/createEntity/accountId123", response.API); @@ -824,7 +824,7 @@ public async Task ExecuteScenarioStep_IncorrectScenario_ThrowNotFoundScenarioExc var parameters = "[{\"Name\": \"Vas\", \"stepName\": \"TestStep\"}]"; //Act - var result = () => _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, null); + var result = () => _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, new StepResponse[]{}, new StepParameters[]{}); //Assert await result.Should().ThrowAsync().WithMessage("Step with name TestStep is not found."); @@ -872,7 +872,7 @@ public async Task ExecuteScenario_CorrectArgument_ReturnsCorrectResponse() new Parameter { RequestParameterPath = "accountId", - Source = null, + Source = string.Empty, In = "Path" } } @@ -921,7 +921,7 @@ public async Task ExecuteScenario_CorrectArgumentWithRandom_ReturnsCorrectRespon new Parameter { RequestParameterPath = "accountId", - Source = null, + Source = string.Empty, In = "Path" } } @@ -989,7 +989,7 @@ public async Task ExecuteScenario_SeveralSteps_ReturnsCorrectResponse() new Parameter { RequestParameterPath = "accountId", - Source = null, + Source = string.Empty, In = "Path" } } @@ -1087,7 +1087,7 @@ public async Task ExecuteScenario_SeveralStepsAndSeveralIterations_ReturnsCorrec new Parameter { RequestParameterPath = "accountId", - Source = null, + Source = string.Empty, In = "Path" } } @@ -1184,7 +1184,7 @@ public async Task ExecuteScenario_SeveralSteps_OneStepFailed_ExecutionOfOtherSte new Parameter { RequestParameterPath = "accountId", - Source = null, + Source = string.Empty, In = "Path" } } From 5db4cafa1b9af0ded8c4ab8daafd3b16b7d8a783 Mon Sep 17 00:00:00 2001 From: annahileta Date: Thu, 16 Nov 2023 15:32:58 +0200 Subject: [PATCH 2/2] added workflow for CI/CD --- .github/workflows/dotnet-desktop.yml | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 .github/workflows/dotnet-desktop.yml diff --git a/.github/workflows/dotnet-desktop.yml b/.github/workflows/dotnet-desktop.yml new file mode 100644 index 0000000..86dac29 --- /dev/null +++ b/.github/workflows/dotnet-desktop.yml @@ -0,0 +1,27 @@ +name: Test .NET + +on: + push: + branches: [ "main" ] + pull_request: + branches: [ "main" ] + +jobs: + build: + + runs-on: windows-latest + + steps: + - uses: actions/checkout@v3 + - name: Add .NET support + uses: actions/setup-dotnet@v2 + with: + dotnet-version: 6.0.x + - name: Add MsBuild + uses: microsoft/setup-msbuild@v1.1.3 + - name: Load dependencies + run: dotnet restore DocuSign.MyAPI\DocuSign.MyAPI.sln + - name: Build project + run: dotnet build DocuSign.MyAPI\DocuSign.MyAPI.sln --no-restore + - name: Run tests + run: dotnet test DocuSign.MyAPI\DocuSign.MyAPI.sln --no-build --verbosity normal