Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate with `eslint-mdx` to lint `.mdx` with `ESLint` #1195

Merged
merged 2 commits into from Oct 24, 2019

Conversation

@JounQin
Copy link
Contributor

JounQin commented Oct 23, 2019

eslint-mdx is a ESLint Parser/Plugin for MDX, helps you lint all ES syntaxes excluding code block of course. Work perfectly with eslint-plugin-import, eslint-plugin-prettier or any other eslint plugins.

It is a complete rewriting from scratch for eslint-plugin-mdx.

It has been landed in mdx-js/mdx#726 for months.


Besides, this monorepo seems not a best practice for using multiple yarn.lock files and a lot of duplicate devDependencies and lint/format scripts between packages, and I would like to raise another PR to optimize them.

@JounQin JounQin changed the title Feat/eslint mdx feat: Add support of eslint-plugin-mdx Oct 23, 2019
@JounQin JounQin changed the title feat: Add support of eslint-plugin-mdx feat: integrate with `eslint-mdx` to lint `.mdx` with `ESLint` Oct 23, 2019
@rakannimer

This comment has been minimized.

Copy link
Member

rakannimer commented Oct 24, 2019

This is great ! Thanks @JounQin

Besides, this monorepo seems not a best practice for using multiple yarn.lock files and a lot of duplicate devDependencies and lint/format scripts between packages, and I would like to raise another PR to optimize them.

That would be awesome ! There's definitely some room for cleanup and optimization.

Feel free to join the docz slack if you'd like and/or have questions

@rakannimer rakannimer merged commit 4805737 into doczjs:master Oct 24, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@JounQin JounQin deleted the JounQin:feat/eslint-mdx branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.