Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(gatsby-theme-docz): keep NavGroup opened on item click #1211

Merged
merged 1 commit into from Oct 29, 2019

Conversation

Kerumen
Copy link
Contributor

@Kerumen Kerumen commented Oct 28, 2019

Description

As all the menu items are now closed by default, if we open one and click on one item, it remount the component and closes it. This PR fixes that by keeping it opened.

@Kerumen Kerumen self-assigned this Oct 28, 2019
Copy link
Contributor

@rakannimer rakannimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Didn't need additional state 👍

@Kerumen Kerumen merged commit ce18cb0 into master Oct 29, 2019
@Kerumen Kerumen deleted the fix-menu-opened branch October 29, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants