Add line color hue shift speed#2
Merged
Merged
Conversation
ddd4c98 to
41d11ff
Compare
doersino
requested changes
May 30, 2021
Owner
There was a problem hiding this comment.
This is a great addition! It creates a very psychedelic (or, pro-LGBT) vibe, which is interesting to play around with.
I've pointed out a few very minor issues (this is my first time trying out GitHub's built-in code review tooling), but it's honestly a great pull request! Thank you very much.
doersino
approved these changes
May 30, 2021
Owner
|
Awesome, thank you so much for addressing my nitpicky requests for changes! I'll go through the presets and check which ones can be improved with a subtle hue shift. |
Contributor
Author
|
Yeah, I preferred not to touch the presets, it is better that you choose the values you like, my taste for colors is not the most refined in the world. Thanks! |
Owner
Contributor
Author
|
Haha, it fits perfectly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added an option to dynamically change the hue of the line color.
Example of what can be done: https://i.imgur.com/18sMupc.png
Config for that example:
#r580ro-0.9rot0.41rota0.59e0.995ex0.996t0.7se6700sk0.04i2000w1200h1200c10ca15can18l255li142lin78line0.49b6f788rotat822wa8508wav3015wavi1.3j0.3linec2hu0.42Comments:
hueshiftspeedoption added at the bottom (following the guidelines)changeHuefunction adapted from here https://stackoverflow.com/a/17433060changeHueand auxiliary functions added bellow other auxiliary functions, betweenrotateandrestartRenderinghueshiftspeed != 0it would be better to store the initial color value as HSL to avoid the RGB->HSL conversion each step. Or even avoiding RGB and specifying the value ashsla(...). I didn't see it worth the effort.