Modernise library #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh, that is strange, Travis did not run the 5.6 build. Not sure why not? |
caciobanu
reviewed
Feb 20, 2018
composer.json
Outdated
| "symfony/yaml": "^2.5|^3.0|^4" | ||
| "php": "^5.6|^7.1", | ||
| "doctrine/mongodb": "^1.0", | ||
| "symfony/console": "^3.3|^4", |
Member
There was a problem hiding this comment.
Why we drop symfony 2.7 and 2.8 and keep 3.3 ? AFAIK 2.7 and 2.8 are still supported.
Contributor
Author
There was a problem hiding this comment.
tbh I saw 2.7 support finishes in May and thought that we don't maintain this library much so might as well drop it - but I had forgotten about 2.8. So I'll restore ^2
caciobanu
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of different changes suggested here to bring the library up to date a bit.
Let me know what you think of them!