From a680438a24e9540d9dba9831021298f47f1c8efe Mon Sep 17 00:00:00 2001
From: Patrick Lodder <patricklodder@users.noreply.github.com>
Date: Fri, 13 Jan 2023 00:30:57 +0100
Subject: [PATCH] ci: enable security and symbol checks for all supported
 targets

This enables running of security checks for macOS and symbol
checks for windows and ARM linux targets with each CI run.

Symbol checks remain disabled for debug and experimental targets
because those aren't production binary releases.

macOS symbol checks need build system patches before it will
work as intended so these have to stay disabled at this point.
---
 .github/workflows/ci.yml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 17a434d6fe..7fc2f0405e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -65,7 +65,7 @@ jobs:
             test-script: |
               qemu-arm -E LD_LIBRARY_PATH=/usr/arm-linux-gnueabihf/lib/ /usr/arm-linux-gnueabihf/lib/ld-linux-armhf.so.3 src/test/test_dogecoin
             check-security: true
-            check-symbols: false
+            check-symbols: true
             dep-opts: "NO_QT=1"
             config-opts: "--enable-glibc-back-compat LDFLAGS=-static-libstdc++"
             goal: install
@@ -101,7 +101,7 @@ jobs:
             test-script: |
               qemu-aarch64 -E LD_LIBRARY_PATH=/usr/aarch64-linux-gnu/lib/ /usr/aarch64-linux-gnu/lib/ld-linux-aarch64.so.1 src/test/test_dogecoin
             check-security: true
-            check-symbols: false
+            check-symbols: true
             dep-opts: "NO_QT=1"
             config-opts: "--enable-zmq --enable-glibc-back-compat LDFLAGS=-static-libstdc++"
             goal: install
@@ -145,7 +145,7 @@ jobs:
             test-script: |
               make check $MAKEJOBS VERBOSE=1
             check-security: true
-            check-symbols: false
+            check-symbols: true
             dep-opts: ""
             config-opts: "--enable-gui=qt5"
             goal: install
@@ -163,7 +163,7 @@ jobs:
             test-script: |
               make check $MAKEJOBS VERBOSE=1
             check-security: true
-            check-symbols: false
+            check-symbols: true
             dep-opts: ""
             config-opts: "--enable-gui=qt5"
             goal: install
@@ -190,7 +190,7 @@ jobs:
             os: ubuntu-18.04
             packages: cmake imagemagick libcap-dev librsvg2-bin libz-dev libtiff-tools libtinfo5 xorriso
             run-bench: false
-            check-security: false
+            check-security: true
             check-symbols: false
             dep-opts: ""
             config-opts: "--with-gui=qt5 --disable-tests"