Skip to content

Fernando Freire
dogonthehorizon

Organizations

@UP-TeamStark
Apr 25, 2016
Apr 16, 2016
Apr 13, 2016
@dogonthehorizon
Apr 10, 2016
Apr 2, 2016
Feb 15, 2016
dogonthehorizon commented on pull request nickmoorman/wikiscraper#1
@dogonthehorizon

If you can guarantee var is of type String (strings are falsey in Python) you could also say: if var: data[ext["target"]["name"]] = var

Feb 15, 2016
dogonthehorizon commented on pull request nickmoorman/wikiscraper#1
@dogonthehorizon

+1

Feb 15, 2016
dogonthehorizon commented on pull request nickmoorman/wikiscraper#1
@dogonthehorizon

I'd also suggest against destructively iterating over this list. Don't have any immediate suggestions on migrating this implementation to something…

Feb 15, 2016
dogonthehorizon commented on pull request nickmoorman/wikiscraper#1
@dogonthehorizon

I'm uncomfortable with this mutation. I'd suggest mutation a copy of data and returning that instead?

Feb 15, 2016
dogonthehorizon commented on pull request nickmoorman/wikiscraper#1
@dogonthehorizon

This can be reduced to, I feel: return text.replace("<syntaxhighlight lang=\"javascript\">", "").replace("</syntaxhighlight>", "")

Feb 15, 2016
dogonthehorizon commented on pull request nickmoorman/wikiscraper#1
@dogonthehorizon

Could also be a permissions issue, right? Not just a FNFE?

Feb 15, 2016
dogonthehorizon commented on pull request nickmoorman/wikiscraper#1
@dogonthehorizon

Clever!

Feb 15, 2016
dogonthehorizon commented on pull request nickmoorman/wikiscraper#1
@dogonthehorizon

General style comment: var names are generally underscored instead of camelCased.

Feb 13, 2016
Feb 9, 2016
Something went wrong with that request. Please try again.