Fix NativeProxy reference tracker #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
added
Bug
|
Not sure what happened, but it fixed the issue I had with MongoDatabase connection. Thanks! |
edewata
approved these changes
Oct 28, 2019
cipherboy
force-pushed
the
fix-nativeproxy
branch
from
099ffe9
to
c77ac07
Compare
In eb5df01, I introduced a bug by setting mPointer after trying to add NativeProxy to the registry. In most instances this won't matter, however, if another instance exists in the HashSet with the same hash value, the equals comparator will be used, triggering a NPE. Signed-off-by: Alexander Scheel <ascheel@redhat.com>
cipherboy
force-pushed
the
fix-nativeproxy
branch
from
c77ac07
to
06f1941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In eb5df01, I introduced a bug by
setting
mPointerafter trying to addNativeProxyto the registry. Inmost instances this won't matter, however, if another instance exists in
the
HashSetwith the same hash value, the equals comparator will beused, triggering a NPE.
Signed-off-by: Alexander Scheel <ascheel@redhat.com>