Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port PKI from apache commons-lang to commons-lang3 #3322

Closed
pki-bot opened this issue Oct 3, 2020 · 1 comment
Closed

port PKI from apache commons-lang to commons-lang3 #3322

pki-bot opened this issue Oct 3, 2020 · 1 comment

Comments

@pki-bot
Copy link

pki-bot commented Oct 3, 2020

This issue was migrated from Pagure Issue #3205. Originally filed by decathorpe (@decathorpe) on 2020-08-13 11:50:55:

  • Assigned to nobody

apache commons-lang 2.x releases are no longer compatible with Java 11 (due to usage of assert and enum as identifiers), and fedora packages are all getting ported to commons-lang3.

I did a quick search of the PKI sources and found no usage of APIs that were removed with commons-lang3, so porting PKI to the new version should be straightforward:

  • change dependency in pom.xml files to org.apache.commons:commons-lang3
  • change import statements in Java files: "s/org\.apache\.commons\.lang\./org.apache.commons.lang3./"

I'm not sure if other parts of the build machinery need to be adapted as well (I'm not that familiar with CMake).


There's also a Java SIG tracking issue for porting packages to commons-lang3.

@edewata
Copy link
Contributor

edewata commented Oct 14, 2020

Fixed in main branch:

@edewata edewata closed this as completed Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants