Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant Crashes in Warcraft III Reforged #1252

Closed
BaDitO2 opened this issue Nov 24, 2019 · 13 comments
Labels

Comments

@BaDitO2
Copy link

@BaDitO2 BaDitO2 commented Nov 24, 2019

Hello,

Warcraft 3 Reforged crashes instantly, as well as the Reforged World editor
errors in d3d11.log
err: DxgiSwapChain::GetFrameLatencyWaitableObject: Not implemented
err: DxgiSwapChain::SetMaximumFrameLatency: Not implemented

Software information

Warcraft 3 Reforged Beta
Build: 1.32.0.13769

System information

  • GPU: RX480 8GB
  • Driver: AMDGPU 19.0.8
  • Wine version: 4.13 staging
  • DXVK version: 1.4.5

Apitrace file(s)

  • Put a link here
    edit wasn't able to do a sucessfull apitrace yet, since the Reforged beta can be only launched via the Battle.net Launcher, and apitrace did only trace the bnet launcher itself.
    edit apitrace in my second reponse

Log files

Warcraft III_dxgi.log

edit same issue as here
https://forums.lutris.net/t/warcraft-iii-reforged-last-patch-broke-it-anyone-been-able-to-fix-it/7629

@doitsujin

This comment has been minimized.

Copy link
Owner

@doitsujin doitsujin commented Nov 24, 2019

Did this game stop supporting Windows 7 or add D3D12 support or something?

I guess it's possible to implement the functions in question (although it's going to be a royal pain in the arse), but it would be weird for a D3D11 game to use these. They are really intended for D3D12.

FWIW I do not have access to the game so an apitrace would be appreciated. You can generate one by copying the files dxgi.dll, dxgitrace.dll and d3d11.dll from apitrace/x64/lib/wrappers next to the game exe (use x86 instead of x64 if this is a 32-bit game).

@BaDitO2

This comment has been minimized.

Copy link
Author

@BaDitO2 BaDitO2 commented Nov 24, 2019

Can't say much about the intentions of the Blizzard Game devs, all I can say the beta also crashes instantly on win7 and win8.1.

Thanks for the tip I will update with a apitrace as soon as I get to it.

@doitsujin

This comment has been minimized.

Copy link
Owner

@doitsujin doitsujin commented Nov 24, 2019

Do note that I will need an apitrace recorded on Windows. wined3d will also most likely not work.

@BaDitO2

This comment has been minimized.

Copy link
Author

@BaDitO2 BaDitO2 commented Nov 24, 2019

Apitrace made on my windows 8.1 machine

Warcraft_III_apitrace.zip

@doitsujin

This comment has been minimized.

Copy link
Owner

@doitsujin doitsujin commented Nov 24, 2019

Yeah that unfortunately isn't very useful either since it fails to create the swap chain on Windows 8.1 and then probably just crashes. Do you have access to a Windows 10 machine?

@BaDitO2

This comment has been minimized.

Copy link
Author

@BaDitO2 BaDitO2 commented Nov 24, 2019

That's useful information for me tho, since as far as I know Blizzard intends on keeping Reforged playable in windows 8.1, so in the end of he day it might not be a job for you guys, but Blizzard's job in fixing windows 8.1 compatibility of Warcraft 3 Reforged.
I will redirect this to the War3 dev team thanks :)

@doitsujin

This comment has been minimized.

Copy link
Owner

@doitsujin doitsujin commented Nov 24, 2019

Well the main problem is that DXVK exposes DXGI 1.5, so the game can expect the missing functionality to be present and we'll have to implement it. I just don't have a test case (I can write one, but that won't show me how this API is actually used by real-world applications, and as far as I know it's the only D3D11 game which needs these).

@BaDitO2

This comment has been minimized.

Copy link
Author

@BaDitO2 BaDitO2 commented Nov 24, 2019

okay. I will upload a Windows 10 apitrace tomorrow (Don't have a single win10 machine at home, but I got access to them at work).

@BaDitO2

This comment has been minimized.

Copy link
Author

@BaDitO2 BaDitO2 commented Nov 25, 2019

Hello,

here is the win10 apitrace (I just launched the game entered the main menu and exited again, since the GPU of the win10 machine is really bad, and I doubt it would run a match of Warcraft 3 Reforged without crash)
But I hope it will help you

Even then the APItrace is 500 MB big in a zipped file, and github would not allow this to be uploaded directly, so I had to share it via my public Gdrive: filename "war3_apitrace_win10.zip"

https://drive.google.com/open?id=1bjCsdzYZ3X1_WDTgzNxIXjpbhUthFxyC

edit windows version is windows 10 1903 pro latest updates in case you need this info

@doitsujin

This comment has been minimized.

Copy link
Owner

@doitsujin doitsujin commented Nov 25, 2019

Thanks, this contains the relevant API calls and is quite helpful indeed.

@doitsujin

This comment has been minimized.

Copy link
Owner

@doitsujin doitsujin commented Nov 26, 2019

Could you check if it works with the dxgi-frame-latency branch? It's more or less untested right now (will do that soon) but it implements the missing functions.

@BaDitO2

This comment has been minimized.

Copy link
Author

@BaDitO2 BaDitO2 commented Nov 26, 2019

Could you check if it works with the dxgi-frame-latency branch? It's more or less untested right now (will do that soon) but it implements the missing functions.

It works with the dxgi-frame-latency build perfectly <3

Thank you very very much <333

@doitsujin

This comment has been minimized.

Copy link
Owner

@doitsujin doitsujin commented Nov 26, 2019

Thanks for the feedback; I fixed a few issues and merged it.

Feel free to reopen if for some reason it broke on the master branch.

@doitsujin doitsujin closed this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.