Merged
Conversation
tomdye
approved these changes
Mar 1, 2019
Member
tomdye
left a comment
tomdye
left a comment
There was a problem hiding this comment.
Gona cause a lot of hurt, but it's for the best!
Should probably raise for build-widget / build-theme etc too.
Nice 👍
agubler
approved these changes
Mar 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 52.48% 52.46% -0.02%
==========================================
Files 10 10
Lines 625 629 +4
Branches 157 157
==========================================
+ Hits 328 330 +2
- Misses 297 299 +2
Continue to review full report at Codecov.
|
matt-gadd
force-pushed
the
strict-css-modules
branch
from
a485bc1 to
ebc13bd
Compare
matt-gadd
force-pushed
the
strict-css-modules
branch
from
ebc13bd to
16237e5
Compare
agubler
approved these changes
Mar 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettierDescription:
This throws warnings in the build if we detect any selectors in
m.cssfiles that can potentially leak into other widgets. The 2 scenario's handled with this PR are any element/tag selectors and the universal selector.