Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict css module checks #251

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@matt-gadd
Copy link
Contributor

commented Mar 1, 2019

Type: feature

The following has been addressed in the PR:

  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:
This throws warnings in the build if we detect any selectors in m.css files that can potentially leak into other widgets. The 2 scenario's handled with this PR are any element/tag selectors and the universal selector.

@tomdye
tomdye approved these changes Mar 1, 2019
Copy link
Member

left a comment

Gona cause a lot of hurt, but it's for the best!
Should probably raise for build-widget / build-theme etc too.
Nice 👍

@agubler
agubler approved these changes Mar 1, 2019
@codecov

This comment has been minimized.

Copy link

commented Mar 1, 2019

Codecov Report

Merging #251 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage   52.48%   52.46%   -0.02%     
==========================================
  Files          10       10              
  Lines         625      629       +4     
  Branches      157      157              
==========================================
+ Hits          328      330       +2     
- Misses        297      299       +2
Impacted Files Coverage Δ
src/base.config.ts 23.75% <50%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16237e5...348dbe3. Read the comment docs.

@matt-gadd matt-gadd force-pushed the matt-gadd:strict-css-modules branch from a485bc1 to ebc13bd Mar 1, 2019

@matt-gadd matt-gadd closed this Mar 21, 2019

@matt-gadd matt-gadd force-pushed the matt-gadd:strict-css-modules branch from ebc13bd to 16237e5 Mar 21, 2019

@matt-gadd matt-gadd reopened this Mar 21, 2019

@matt-gadd matt-gadd merged commit 687a8ed into dojo:master Mar 21, 2019

3 of 5 checks passed

codecov/patch 50% of diff hit (target 52.48%)
Details
codecov/project 52.46% (-0.02%) compared to 16237e5
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.