Skip to content

Always serve compressed content when using --serve option#257

Merged
agubler merged 1 commit intodojo:masterfrom
agubler:serve-gzip
Mar 21, 2019
Merged

Always serve compressed content when using --serve option#257
agubler merged 1 commit intodojo:masterfrom
agubler:serve-gzip

Conversation

@agubler
Copy link
Copy Markdown
Member

@agubler agubler commented Mar 21, 2019

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

When either running in dev or dist without specific compression options, use the standard compression express middleware for serving static in --serve mode.

Resolves #254

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2019

Codecov Report

Merging #257 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   52.17%   52.32%   +0.15%     
==========================================
  Files          10       10              
  Lines         621      623       +2     
  Branches      156      156              
==========================================
+ Hits          324      326       +2     
  Misses        297      297
Impacted Files Coverage Δ
src/main.ts 88.76% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507e2fb...b54a06c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants