Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always serve compressed content when using `--serve` option #257

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@agubler
Copy link
Member

commented Mar 21, 2019

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

When either running in dev or dist without specific compression options, use the standard compression express middleware for serving static in --serve mode.

Resolves #254

@codecov

This comment has been minimized.

Copy link

commented Mar 21, 2019

Codecov Report

Merging #257 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   52.17%   52.32%   +0.15%     
==========================================
  Files          10       10              
  Lines         621      623       +2     
  Branches      156      156              
==========================================
+ Hits          324      326       +2     
  Misses        297      297
Impacted Files Coverage Δ
src/main.ts 88.76% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507e2fb...b54a06c. Read the comment docs.

@agubler agubler merged commit 6ff5d7e into dojo:master Mar 21, 2019

5 checks passed

codecov/patch 100% of diff hit (target 52.17%)
Details
codecov/project 52.32% (+0.15%) compared to 507e2fb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.