Provide validation .dojorc logic and schema for cli-build-app #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 48.53% 48.76% +0.22%
==========================================
Files 10 10
Lines 684 687 +3
Branches 193 193
==========================================
+ Hits 332 335 +3
Misses 352 352
Continue to review full report at Codecov.
|
agubler
reviewed
Sep 27, 2019
| "functional" | ||
| ] | ||
| }, | ||
| "watch": { |
There was a problem hiding this comment.
This isn't correct any more, it is a boolean.
agubler
reviewed
Oct 29, 2019
| "base" : { | ||
| "type": "string" | ||
| }, | ||
| "build-time-render": { |
There was a problem hiding this comment.
Can we add a couple more options for build-time-render?
renderer: 'jsdom' | 'puppeteer'
discoverPaths: boolean
|
|
agubler
approved these changes
Oct 30, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettierDescription:
I closed #223 because it was branching off of
dojo/cli-build-apprather than my forked repo.This PR provides the necessary schema and validation function for providing validation for the
cli-build-apppackage. Users will have their application.dojorcconfigs validated before running the build. allowing them to know up front if their configuration is valid.Resolves ##222