Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide validation .dojorc logic and schema for cli-build-app #324

Merged
merged 21 commits into from Oct 30, 2019

Conversation

JamesLMilner
Copy link
Contributor

@JamesLMilner JamesLMilner commented Sep 25, 2019

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

I closed #223 because it was branching off of dojo/cli-build-app rather than my forked repo.

This PR provides the necessary schema and validation function for providing validation for the cli-build-app package. Users will have their application .dojorc configs validated before running the build. allowing them to know up front if their configuration is valid.

Resolves ##222

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #324 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   48.53%   48.76%   +0.22%     
==========================================
  Files          10       10              
  Lines         684      687       +3     
  Branches      193      193              
==========================================
+ Hits          332      335       +3     
  Misses        352      352
Impacted Files Coverage Δ
src/main.ts 88.95% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c8338...17d038e. Read the comment docs.

@JamesLMilner JamesLMilner requested review from agubler and matt-gadd Sep 26, 2019
"functional"
]
},
"watch": {
Copy link
Member

@agubler agubler Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct any more, it is a boolean.

Copy link
Contributor Author

@JamesLMilner JamesLMilner Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"base" : {
"type": "string"
},
"build-time-render": {
Copy link
Member

@agubler agubler Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a couple more options for build-time-render?

renderer: 'jsdom' | 'puppeteer'
discoverPaths: boolean

@jsf-clabot
Copy link

jsf-clabot commented Oct 30, 2019

CLA assistant check
All committers have signed the CLA.

@JamesLMilner JamesLMilner merged commit ea0fb83 into dojo:master Oct 30, 2019
5 checks passed
@agubler agubler mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants