Permalink
Commits on Aug 8, 2016
  1. Fix typos causing console errors, fixes #18851, refs #6236.

    Theoretically this is already tested in Tree_a11y.html,
    in the "destroy and focus" test suite.  Unfortunately I can't
    run the test because robot is giving an error about _setKey()
    being undefined.
    wkeese committed Aug 7, 2016
Commits on Apr 13, 2016
  1. Fix exception during RadioButton creation when has-bidi: true.

    Fixes #18831, refs #18185.
    wkeese committed Apr 13, 2016
Commits on Mar 11, 2016
Commits on Mar 1, 2016
  1. Fix regression where visibility:visible elements in unselected panes …

    …became visible,
    
    Fixes #18612, fixes #18799.
    wkeese committed Mar 1, 2016
  2. Fix spurious test failure from ddf5304.

    Refs #18797.
    wkeese committed Mar 1, 2016
Commits on Jan 3, 2016
  1. Remove widgetsInTemplate property and instead auto-detect

    whether or not template contains widgets.
    
    Fixes #18768.
    wkeese committed Dec 31, 2015
  2. Make unfocused NumberSpinners and Sliders ignore mousewheel events.

    Avoids problems when the user scrolls the page and the cursor happens
    to pass over one of those controls.
    
    Manually tested only, because it's hard to automate this test (although
    robot does support mousewheel).
    
    Fixes #18300.
    wkeese committed Dec 31, 2015
  3. Right-align numbers in NumberTextBox etc.

    Fixes #10377.
    wkeese committed Dec 31, 2015
Commits on Dec 3, 2015
  1. Clear dropdown width setting (due to autoWidth:true) when dropdown is…

    … closed.
    
    Fixes problem when dropdown width changes from narrow to wide, but it's still
    (incorrectly) constrained to width of anchor node.
    
    Fixes #18454
    wkeese committed Dec 2, 2015
Commits on Dec 1, 2015
  1. Clear dropdown scrollbar if viewport size increased.

    Since open() sets overflowY rather than overflow, hide() should do the same.
    Traces back to 4d1ddb9 (refs #10631).
    
    Fixes #18511.
    wkeese committed Dec 1, 2015
Commits on Nov 25, 2015
  1. Fix hitting ENTER in the Editor when running Jaws.

    Fixes #18757.
    
    Also make sure that editor document gets valid setting for "lang" attr.
    Fixes #18758, refs #16140, refs #18731 tangentially.
    
    Finally, fixes an escaping issue when the Editor label was specified via
    aria-label="..." and the value contains special characters.  The fix uses
    string.escape() which is (currently) only in dojo core 1.10+.
    wkeese committed Nov 17, 2015
Commits on Oct 30, 2015
Commits on Oct 14, 2015
  1. Make Editor work (more or less) on Edge.

    There may be more issues... since doh/robot doesn't run on Edge
    I can't test Editor properly.  One problem I did notice was with
    the first time you highlight some text and use the LinkDialog.
    But it works fine if you open the LinkDialog again.
    
    Fixes #18720.
    wkeese committed Oct 12, 2015
  2. Remove inadvertent tabindex setting, and do other cleanup.

    Note that role="main" is not a valid setting for <body>.
    Refs #12250 tangentially.
    wkeese committed Oct 12, 2015
Commits on Oct 8, 2015
Commits on Oct 7, 2015
  1. Put role=main on Editor's <div> rather than <body>,

    since "main" is an invalid role for <body>.
    
    Fixes #18731, refs #16140.
    wkeese committed Oct 7, 2015
Commits on Oct 5, 2015
  1. Workaround hang in focus_mouse.html test on IE10

    triggered by d26af75.
    
    Starting with that change and only occuring with certain timing,
    the onload event on initRobot()'s iframe (created from dojo/robotx.js)
    never fires, even though the test_focusWidget.html page has finished
    loading and initializing.
    
    Strangely, this problem only seems to happen on tests/_base/robot/focus_mouse.html,
    which is a deprecated test superceded by tests/focus.html.  So for now I just removed
    the Editor from the test_focusWidget.html.  If we start to see more serious problems,
    will need to make a bigger fix, perhaps rolling back
    d26af75.
    
    Refs #18715.
    wkeese committed Oct 5, 2015
Commits on Oct 2, 2015
  1. Disable robot tests on Edge and Chrome, since those browsers don't su…

    …pport Java
    
    and thus can't run DOH robot.
    
    Refs #18723.
    wkeese committed Sep 30, 2015
  2. Always append Editor's <iframe> to document before setting src.

    Fixes problem on IE11 where you can't enter text
    if "Active Scripting" is disabled for the "Internet" zone.
    
    The old code path is no longer needed because (starting with Dojo 1.9)
    IE6 and IE7 are no longer supported.
    
    Fixes #18715.
    wkeese committed Sep 30, 2015
Commits on Aug 27, 2015
  1. Handle case (bug?) on Android/Chrome with word suggestion IME

    where printable characters produce keydown event but no keypress event.
    
    Fixes #18673, refs #14703.
    wkeese committed Aug 27, 2015
Commits on Aug 24, 2015
  1. Fix regression when app overrides the _TextBoxMixin#onInput() method.

    Also, the TextBox_onInput.html conversion from widget.connect() to aspect.after() was wrong.  The
    callback to aspect.after() gets two parameters: the result of the original function and the list of args to the
    original function.  But for this test we can just override onInput() rather than setting up advice on it.
    
    Fixes #18673, refs #14703, #18396, #18501.
    wkeese committed Aug 22, 2015
Commits on Jul 22, 2015
  1. Use visiblity:hidden rather than display:none to hide TabContainer pa…

    …nes.
    
    Fixes problem where scroll position lost when switching back to tabs.
    
    Tried to do this a long time ago but ran into problems with IE6 (refs #5672).
    But things seem to be OK with IE8+.
    
    This leaves all the old infrastructure code in place to call resize() on descendant
    widgets as they become visible.  Probably some of that infrastructure is no longer
    needed.
    
    Fixes #18612.
    wkeese committed Jul 21, 2015
  2. Remove test that no longer makes sense, refs #18563.

    Now when you type "99" into the real-number spinner and tab away,
    it auto-converts it to 99.0, rather than showing an error.
    wkeese committed Jul 21, 2015
Commits on Jul 4, 2015
  1. Optimize rendering TimePicker items.

    Refs #7631.
    wkeese committed Jul 2, 2015
Commits on Jun 28, 2015
  1. Keep Dialog within viewport when viewport shrunk.

    This avoids the bug where clicking the underlay (when the dialog is offscreen)
    will scroll the viewport in a weird way.
    
    Fixes #18618.
    wkeese committed Jun 28, 2015
Commits on Jun 25, 2015
  1. When showRoot=false, Tree's root node shouldn't have aria-selected at…

    …tribute.
    
    Fixes #18617.
    wkeese committed Jun 25, 2015
  2. ViewSource plugin: hide Editor's iframe by setting visiblity:hidden n…

    …ot display:none.
    
    Fixes a few bugs after viewing source and then switching back to editor:
    
    - loss of scroll position
    - weird FF bug where clicking an image makes it show double
    
    There was/is an issue where viewing source makes the editor shrink a little bit.
    I lessened the problem by removing vestigial IE6 & IE7 resize related code.
    But it's still there somewhat.
    
    Fixes #18607.
    wkeese committed Jun 25, 2015
Commits on May 28, 2015
  1. Fix _Contained#getNextSibling() when parent is StackContainer.

    The downside is that this slows down the execution for the common case, from O(1)
    to O(n).  If performance becomes an issue, could replace it with a (more complicated)
    incremental DFS.
    
    Fixes #18595.
    wkeese committed May 28, 2015
Commits on May 25, 2015
  1. Remove vestigial code breaking search from Polish keyboard.

    On a Polish keyboard, the keypress events for some non-ascii characters like
    € and Ł (input on a Polish keyboard by pressing Right-Alt+U and Right-Alt+Shift+L)
    have ctrlKey and altKey set.  Yet, the events should still be processed because
    they correspond to printable characters.
    
    Fixes #18594, building on 0540738
    (refs #18396, refs #18501).
    wkeese committed May 25, 2015
Commits on May 8, 2015
  1. Don't set aria-disabled attribute on <input> nodes.

    It's redundant with the disabled property.
    Fixes #18591.
    wkeese committed May 7, 2015
Commits on May 7, 2015
  1. Put Calendar's aria-labelledby attribute back on the root node.

    Also, due to the Calendar template change, the root node is role=presentation not role=grid.
    
    Refs #16210, refs #16307.
    wkeese committed May 7, 2015
Commits on May 4, 2015
  1. Avoid floating point errors on Slider value.

    Also various cleanup to the test scripts.
    Thanks to Arunas Ruksnaitis for the fix to the code.
    
    Fixes #7176, fixes #18579.
    wkeese committed May 4, 2015
Commits on May 2, 2015
  1. Calendar: modify template to pull month and year out of the <table>.

    If users have custom CSS for Calendar, they may need to modify it.
    
    Also, although the tundra CSS was specifying a border between the days and the years,
    it wasn't appearing for some reason (before this change).  Thererfore, I removed that
    line of CSS so there's no border after this change either.
    
    Fixes #16210.
    wkeese committed May 2, 2015
Commits on May 1, 2015
  1. Fix leftClick context menu keyboard open.

    Regression from a160390.
    Fixes #18507, refs #17769.
    wkeese committed May 1, 2015