New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop version from distribution typings #27

Closed
kitsonk opened this Issue Mar 11, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@kitsonk
Member

kitsonk commented Mar 11, 2016

Currently, we append a version number to the typings. For example, dojo/loader@2.0.0-beta.1 has a typings file of dist/typings/dojo-loader/dojo-loader-2.0.0-beta.1.d.ts. This makes it very difficult for consuming packages to semver to something like ~2.0.0 and integrate the typings into their project, because they keep moving around with every upgrade. Most other projects don't version their typings files.

There still isn't clear guidance/solutions yet from the TypeScript team on typing versioning, so until then, it would be a lot less headache to have a consistent filename per package and allow people to manage the versioning through a package manager.

@kitsonk kitsonk added the discussion label Mar 11, 2016

@kitsonk kitsonk added this to the alpha.1 milestone Mar 11, 2016

@kitsonk kitsonk modified the milestones: April 2016, alpha.1 Apr 8, 2016

@kitsonk kitsonk added enhancement and removed discussion labels Apr 21, 2016

@kitsonk

This comment has been minimized.

Show comment
Hide comment
@kitsonk

kitsonk Apr 21, 2016

Member

This on is driving me insane (and is causing all sorts of CI failure). I am going to start implementing it.

Member

kitsonk commented Apr 21, 2016

This on is driving me insane (and is causing all sorts of CI failure). I am going to start implementing it.

@kitsonk kitsonk assigned kitsonk and unassigned vansimke Apr 21, 2016

@kitsonk

This comment has been minimized.

Show comment
Hide comment

kitsonk added a commit to kitsonk/dojo2-package-template that referenced this issue Apr 21, 2016

kitsonk added a commit to dojo/core that referenced this issue Apr 21, 2016

kitsonk added a commit to dojo/loader that referenced this issue Apr 21, 2016

kitsonk added a commit to dojo/dom that referenced this issue Apr 21, 2016

kitsonk added a commit to dojo/parser that referenced this issue Apr 21, 2016

kitsonk added a commit to dojo/compose that referenced this issue Apr 21, 2016

kitsonk added a commit to dojo/i18n that referenced this issue Apr 21, 2016

kitsonk added a commit to dojo/widget-core that referenced this issue Apr 21, 2016

kitsonk added a commit to dojo/actions that referenced this issue Apr 21, 2016

kitsonk added a commit that referenced this issue Apr 21, 2016

@kitsonk

This comment has been minimized.

Show comment
Hide comment
@kitsonk

kitsonk Apr 21, 2016

Member

We will take care of routing and crypto when we get around to refreshing those packages, so I will close this for now.

Member

kitsonk commented Apr 21, 2016

We will take care of routing and crypto when we get around to refreshing those packages, so I will close this for now.

@kitsonk kitsonk closed this Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment