Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event 'position' deprecation warning (#18702) #161

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@gavinr
Copy link
Contributor

gavinr commented Aug 25, 2015

Resolving event 'position' deprecation warning in chrome by using "loaded" property instead.

Resolves 18544 (https://bugs.dojotoolkit.org/ticket/18544)

Existing test cases should cover this trivial change.

My CLA username: gavinr

event 'position' deprecation warning
Resolving event 'position' deprecation warning in chrome by using "loaded" property instead.

Resolves 18544 (https://bugs.dojotoolkit.org/ticket/18544)
@dylans

This comment has been minimized.

Copy link
Member

dylans commented Sep 11, 2015

@gavinr to make sure this works with older browsers also, it should probably be:

response.loaded = ('loaded' in evt) ? evt.loaded : evt.position;

Care to update your PR? Otherwise I'll just update.

@dylans dylans changed the title event 'position' deprecation warning event 'position' deprecation warning (#18702) Sep 11, 2015

@dylans dylans added the bug label Sep 11, 2015

@dylans dylans self-assigned this Sep 11, 2015

@wkeese

This comment has been minimized.

Copy link
Member

wkeese commented Sep 11, 2015

BTW you don't need those parentheses.

@dylans

This comment has been minimized.

Copy link
Member

dylans commented Sep 11, 2015

Not strictly needed per the Dojo 1 style guidelines, but it adds clarity. :)

event 'position' deprecation warning
Resolving event 'position' deprecation warning in chrome by using "loaded" property instead.

Resolves 18544 (https://bugs.dojotoolkit.org/ticket/18544)
@gavinr

This comment has been minimized.

Copy link
Contributor Author

gavinr commented Sep 11, 2015

Updated! Thanks.

@dylans

This comment has been minimized.

Copy link
Member

dylans commented Sep 11, 2015

Thanks @gavinr , closed via d400e28. Backported to 1.10 (877cfa6)

@dylans dylans closed this Sep 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.