Fix potential XSS vulnerability#307
Merged
bryanforbes merged 1 commit intodojo:masterfrom Aug 10, 2018
Merged
Conversation
dylans
approved these changes
Jul 31, 2018
dylans
approved these changes
Aug 6, 2018
* Escape text coming from URL that is used in the page * Comment out the contents of unit.html * Prevent remote scripts being executed * Remove remote URLs from unit test file
bryanforbes
force-pushed
the
fix-code-execution
branch
from
361cf05 to
f224253
Compare
bryanforbes
added a commit
that referenced
this pull request
Aug 10, 2018
* Escape text coming from URL that is used in the page * Comment out the contents of unit.html * Prevent remote scripts being executed * Remove remote URLs from unit test file (cherry picked from commit 9117ffd)
bryanforbes
added a commit
that referenced
this pull request
Aug 10, 2018
* Escape text coming from URL that is used in the page * Comment out the contents of unit.html * Prevent remote scripts being executed * Remove remote URLs from unit test file (cherry picked from commit 9117ffd)
bryanforbes
added a commit
that referenced
this pull request
Aug 10, 2018
* Escape text coming from URL that is used in the page * Comment out the contents of unit.html * Prevent remote scripts being executed * Remove remote URLs from unit test file (cherry picked from commit 9117ffd)
bryanforbes
added a commit
that referenced
this pull request
Aug 10, 2018
* Escape text coming from URL that is used in the page * Comment out the contents of unit.html * Prevent remote scripts being executed * Remove remote URLs from unit test file (cherry picked from commit 9117ffd)
bryanforbes
added a commit
that referenced
this pull request
Aug 10, 2018
* Escape text coming from URL that is used in the page * Comment out the contents of unit.html * Prevent remote scripts being executed * Remove remote URLs from unit test file (cherry picked from commit 9117ffd)
bryanforbes
added a commit
that referenced
this pull request
Aug 10, 2018
* Escape text coming from URL that is used in the page * Comment out the contents of unit.html * Prevent remote scripts being executed * Remove remote URLs from unit test file (cherry picked from commit 9117ffd)
Member
Author
This was referenced May 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this is in a DOH test that isn't used anymore nor run automatically, the threat is minimal.