New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to deep copy FormData #316

Merged
merged 2 commits into from Aug 30, 2018

Conversation

Projects
None yet
2 participants
@agubler
Copy link
Member

agubler commented Aug 17, 2018

The fix for #293 caused a breakage with FormData uploads, this changes leaves the fix in but skips the copy if the object an instance of Formdata

Resolves: #293

agubler added some commits Aug 17, 2018

@dylans

dylans approved these changes Aug 17, 2018

@dylans dylans added this to the 1.14.1 milestone Aug 17, 2018

@dylans dylans merged commit 0463f69 into dojo:master Aug 30, 2018

1 check passed

licence/cla Contributor License Agreement is signed.
Details

dylans added a commit that referenced this pull request Aug 30, 2018

Do not attempt to deep copy FormData (#316)
* Do not deep copy form data

* Update package.json

(cherry picked from commit 0463f69)
@dylans

This comment has been minimized.

Copy link
Member

dylans commented Aug 30, 2018

Backported to 1.14 as c38f5a7.

dylans added a commit that referenced this pull request Sep 9, 2018

Do not attempt to deep copy FormData (#316)
* Do not deep copy form data

* Update package.json

(cherry picked from commit 0463f69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment