Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent all Elements from being deep copied fixes #336 #353

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@jamesshaw1987
Copy link
Contributor

jamesshaw1987 commented Apr 25, 2019

Possibly overlooking something, but I can't see why any Element would ever need to be processed by deepCopy.

@wkeese

This comment has been minimized.

Copy link
Member

wkeese commented Apr 26, 2019

Makes sense to me.

@dylans
dylans approved these changes May 31, 2019
Copy link
Member

dylans left a comment

I’ll land this as soon as possible... need to land this and a few other fixes and then I’ll do another wave of minor releases.

@dylans
dylans approved these changes Sep 4, 2019
@dylans dylans merged commit 30c81b7 into dojo:master Sep 4, 2019
1 check passed
1 check passed
licence/cla Contributor License Agreement is signed.
Details
dylans added a commit that referenced this pull request Sep 4, 2019
dylans added a commit that referenced this pull request Sep 4, 2019
dylans added a commit that referenced this pull request Sep 4, 2019
@dylans

This comment has been minimized.

Copy link
Member

dylans commented Sep 4, 2019

Backported as:

@dylans dylans added this to the 1.15.1 milestone Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.