Prevent all Elements from being deep copied fixes #336 #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Makes sense to me. |
dylans
approved these changes
May 31, 2019
Member
dylans
left a comment
dylans
left a comment
There was a problem hiding this comment.
I’ll land this as soon as possible... need to land this and a few other fixes and then I’ll do another wave of minor releases.
dylans
approved these changes
Sep 4, 2019
dylans
pushed a commit
that referenced
this pull request
Sep 4, 2019
dylans
pushed a commit
that referenced
this pull request
Sep 4, 2019
dylans
pushed a commit
that referenced
this pull request
Sep 4, 2019
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly overlooking something, but I can't see why any Element would ever need to be processed by deepCopy.