Updates to handle when a call to obj.getBoundingClientRect() throws an error or returns an empty object #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error or returns an empty object This update adds a getBoundingClientRect(node) function to dom-geometry that will call node.getBoundingClientRect() but if it throws an error (this can happen in IE when the node is not in the DOM) or an empty object is returned (this can happen in Edge when the node is not in the DOM) an object wil all values set to 0 will be returned. This will prevent errors when the node is not in the DOM.
|
This seems like a step backwards, if getBoundingClientRect() fails isn't it better to throw an error than to return a non-sensical value? |
|
From what I can tell, FireFox and Chrome currently return { x: 0, y: 0, width: 0, height: 0, top: 0, right: 0, bottom: 0, left: 0 } when the node is not on the DOM. I was trying to get the browsers to behave consistently. I leaned towards the option that returned an object in the format that was expected so the calculations that use it could continue without throwing an error. |
|
Hmm, I agree consistency is a good thing. |
dylans
approved these changes
Sep 4, 2019
|
As this is a new addition, it will get added for 1.16.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds a getBoundingClientRect(node) function to dom-geometry
that will call node.getBoundingClientRect() but if it throws an error
(this can happen in IE when the node is not in the DOM) or an empty
object is returned (this can happen in Edge when the node is not in the
DOM) an object with all values set to 0 will be returned. This will
prevent errors when the node is not in the DOM.
fixes #356