Implement ES2018 Promise.prototype.finally in dojo/promise/Promise #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #352
Implementing ES2018's
Promise.prototype.finally
in dojo/promise/Promise instead of dojo/Deferred because:"finally"
method in dojo/promise/Promise that is left without an implementation in Promise instances built in dojo/_base/Deferred. Sonew baseDeferred().promise.finally(function(){})
would throw the "abstract"TypeError
. Implementing in dojo/promise/Promise allows all Deferreds that use this Promise class to inheritfinally
in theirpromise
objects -- dojo/Deferred, dojo/_base/Deferred, and even any (hypothetical?) custom Deferred classes built by users.finally
can be implemented directly in terms ofthen
with reduced complexity over the previous implementation - at runtime, computationally, and in the source.Includes comprehensive, passing unit tests in tests/unit/promise/Promise.js.