Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test of 'Transfer-Encoding' header in chunked onProgress handler. #90

Closed
wants to merge 1 commit into from

Conversation

hwinkler
Copy link

fixes #17823, add Add support for onProgress event when using Chunked…

For cross-origin requests, the browser will not generally allow you to
query any except "simple response headers". Transfer-Encoding isn't
one of them.

fixes #17823, add Add support for onProgress event when using Chunked…

For cross-origin requests, the browser will not generally allow you to
query any except "simple response headers". Transfer-Encoding isn't
one of them.
@hwinkler
Copy link
Author

CLA is under hughw at hughw net

@hwinkler
Copy link
Author

I verified on my own code that this change relieves the problem of Chrome throwing an exception at the getResponseHeader call, and doesn't introduce any new problems in Chrome or Firefox on OS X. I don't know how best to make a test case in dojo style, to create a service that would return a long, chunked response.

@dylans
Copy link
Member

dylans commented May 22, 2014

The pull request seems reasonable. I'll try to land it tomorrow.

@cjolif
Copy link
Member

cjolif commented May 23, 2014

my concern is that this is an enhancement and as far I as know we should be past the enhancement deadline for 1.10. If we start sticking in enhancements where do we stop?

@dylans
Copy link
Member

dylans commented May 23, 2014

@cjolif It's a regression of an enhancement that landed prior to beta.

@cjolif
Copy link
Member

cjolif commented May 23, 2014

oh ok!

@dylans
Copy link
Member

dylans commented May 24, 2014

Closed via 1bc1d7a

@dylans dylans closed this May 24, 2014
@dylans
Copy link
Member

dylans commented May 24, 2014

Thanks @hwinkler ... note that because you submitted this pull request from your master instead of a branch, you'll want to reset HARD your repo against the dojo master to stay in sync.

@hwinkler
Copy link
Author

Ok, thanks Dylan.

On Sat, May 24, 2014 at 8:03 AM, Dylan Schiemann
notifications@github.comwrote:

Thanks @hwinkler https://github.com/hwinkler ... note that because you
submitted this pull request from your master instead of a branch, you'll
want to reset HARD your repo against the dojo master to stay in sync.


Reply to this email directly or view it on GitHubhttps://github.com//pull/90#issuecomment-44086431
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants