Drop version from distribution typings #27

Closed
kitsonk opened this Issue Mar 11, 2016 · 3 comments

Projects

None yet

2 participants

@kitsonk
Member
kitsonk commented Mar 11, 2016

Currently, we append a version number to the typings. For example, dojo/loader@2.0.0-beta.1 has a typings file of dist/typings/dojo-loader/dojo-loader-2.0.0-beta.1.d.ts. This makes it very difficult for consuming packages to semver to something like ~2.0.0 and integrate the typings into their project, because they keep moving around with every upgrade. Most other projects don't version their typings files.

There still isn't clear guidance/solutions yet from the TypeScript team on typing versioning, so until then, it would be a lot less headache to have a consistent filename per package and allow people to manage the versioning through a package manager.

@kitsonk kitsonk added the discussion label Mar 11, 2016
@kitsonk kitsonk added this to the alpha.1 milestone Mar 11, 2016
@vansimke vansimke was assigned by kitsonk Mar 18, 2016
@kitsonk kitsonk modified the milestone: April 2016, alpha.1 Apr 8, 2016
@kitsonk kitsonk added enhancement and removed discussion labels Apr 21, 2016
@kitsonk
Member
kitsonk commented Apr 21, 2016

This on is driving me insane (and is causing all sorts of CI failure). I am going to start implementing it.

@kitsonk kitsonk assigned kitsonk and unassigned vansimke Apr 21, 2016
@kitsonk kitsonk added a commit to kitsonk/dojo2-package-template that referenced this issue Apr 21, 2016
@kitsonk kitsonk Remove version number from typings
Refs #27
5165708
@kitsonk kitsonk added a commit to dojo/core that referenced this issue Apr 21, 2016
@kitsonk kitsonk Remove version number for distribution typings. 7499669
@kitsonk kitsonk added a commit to dojo/loader that referenced this issue Apr 21, 2016
@kitsonk kitsonk Remove version number for distribution typings. d2503a2
@kitsonk kitsonk added a commit to dojo/dom that referenced this issue Apr 21, 2016
@kitsonk kitsonk Remove version number for distribution typings. ba16d76
@kitsonk kitsonk added a commit to dojo/parser that referenced this issue Apr 21, 2016
@kitsonk kitsonk Remove version number for distribution typings. b30e6b0
@kitsonk kitsonk added a commit to dojo/compose that referenced this issue Apr 21, 2016
@kitsonk kitsonk Remove version number for distribution typings. eaf9e51
@kitsonk kitsonk added a commit to dojo/i18n that referenced this issue Apr 21, 2016
@kitsonk kitsonk Remove version number for distribution typings. a802730
@kitsonk kitsonk added a commit to dojo/widgets that referenced this issue Apr 21, 2016
@kitsonk kitsonk Remove version number for distribution typings. 2da99ad
@kitsonk kitsonk added a commit to dojo/actions that referenced this issue Apr 21, 2016
@kitsonk kitsonk Remove version number for distribution typings. 3519b15
@kitsonk
Member
kitsonk commented Apr 21, 2016

We will take care of routing and crypto when we get around to refreshing those packages, so I will close this for now.

@kitsonk kitsonk closed this Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment