Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTE: support rtl direction setting for tables #28

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@semion1956
Copy link
Contributor

commented Aug 27, 2013

@wkeese

This comment has been minimized.

Copy link

commented on editor/plugins/NormalizeIndentOutdent.js in 5bf0c5a Nov 1, 2013

I understand what your goal is, but you can't just make the BidiSupport plugin silently disable the NormalizeIndentOutdent plugin.

Instead, perhaps BidiSupport can set up some sort of advice in the editor to get notified before and/or after the indent operation executes, to do bidi related cleanup.

@wkeese

This comment has been minimized.

Copy link

commented on editor/plugins/TablePlugins.js in 5bf0c5a Nov 1, 2013

why the change?

This comment has been minimized.

Copy link

replied Jan 1, 2014

Still waiting for an answer to this.

@wkeese

This comment has been minimized.

Looks like the change to the table plugin can be independent of the other changes?

@wkeese

This comment has been minimized.

Copy link
Member

commented Jan 1, 2014

As I mentioned in dojo/dijit#6, these pull requests should be more granular, but I'll convert this pull request into one for the TablePlugin changes. I filed https://bugs.dojotoolkit.org/ticket/17654 to track it.

@wkeese

This comment has been minimized.

Copy link
Member

commented Apr 30, 2014

I'm closing this until I get an answer for #28 (comment), and also to have the NormalizeIndentOutdent changes removed from the patch.

@wkeese wkeese closed this Apr 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.