Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[cla] Convert to AMD #82
HI @agavrilov thanks for your contribution! Can you please tell us who you are, so we can check to see if you have a CLA on file ( https://github.com/dojo/dojox/blob/master/CONTRIBUTING.md#contributor-license-agreement ). Also, if you could reference a corresponding bug in dojo as noted in the instructions at https://github.com/dojo/dojox/blob/master/CONTRIBUTING.md#6-issue-a-pull-request , that will help us make sure it gets resolved to our next release, updated in the documentation, etc. Thanks, and let me know if you have any questions.
Hi @agavrilov, I noted a few things that need to be fixed in this PR. Once those are addressed, I believe this will be ready to merge.
One more thing I noticed is that some the tests for these modules need to be updated to AMD as well. If you want to update them, go ahead. Otherwise, I will look at updating them when we merge this PR.