Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully converts LightboxNano to AMD and dojo 1.9.3 #84

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@speich
Copy link
Contributor

commented Mar 26, 2014

CLA is available

See https://bugs.dojotoolkit.org/ticket/17817

- fully converts LightboxNano to AMD and dojo 1.9.3
- adds enhancement to use classes instead of inline styles: https://bugs.dojotoolkit.org/ticket/12202
- fixes bug broken in IE8: https://bugs.dojotoolkit.org/ticket/14430
@speich

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2014

Tested with https://github.com/speich/dojox/blob/master/image/tests/test_LightboxNano.html in FF 29 (Beta), Chrome 33, IE11, IE8, IE7 and Safari 5.1.7 on Windows 7

@gaurav21r

This comment has been minimized.

Copy link
Contributor

commented May 5, 2014

+1 When can we merge this?

@wkeese

This comment has been minimized.

Copy link
Member

commented May 6, 2014

@speich thanks for the work on this! Your change looks good to me, so I pushed it as cd3aca8.

@wkeese wkeese closed this May 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.