Update packaging, upgrade to TypeScript 1.8 #33

Merged
merged 7 commits into from Apr 11, 2016

Projects

None yet

6 participants

@kitsonk
Member
kitsonk commented Feb 24, 2016
  • Migrate to npm only for dependencies
  • Add typings to package.json for distribution builds
  • Remove the _modules path
  • Update form.ts to be compatible with TS 1.8
  • Update other npm dependencies to latest versions
  • Amend tslint.json to be compatible latest version
@kitsonk kitsonk Update packaging, upgrade to TypeScript 1.8
- Migrate to npm only for dependencies
- Add typings to package.json for distribution builds
- Remove the _modules path
- Update form.ts to be compatible with TS 1.8
- Update other npm dependencies to latest versions
- Amend tslint.json to be compatible latest version
9c5adda
@Tomdye Tomdye was assigned by kitsonk Feb 24, 2016
@Tomdye Tomdye commented on an outdated diff Feb 24, 2016
typings/tsd.d.ts
@@ -1 +1,3 @@
-///<reference path="../_modules/dojo-core/typings/dojo-core/dojo-core-2.0.0-pre.d.ts"/>
+///<reference path="../node_modules/dojo-core/typings/dojo-core/dojo-core-2.0.0-alpha.2.d.ts"/>
+/// <reference path="../node_modules/dojo-loader/typings/dojo-loader/dojo-loader-2.0.0-alpha.4.d.ts" />
+/// <reference path="../tests/typings/node/node.d.ts" />
@Tomdye
Tomdye Feb 24, 2016 Member

missing new line EOF

@Tomdye
Member
Tomdye commented Feb 24, 2016

Looks good 👍

@kfranqueiro kfranqueiro commented on an outdated diff Feb 25, 2016
typings/tsd.d.ts
@@ -1 +1,3 @@
-///<reference path="../_modules/dojo-core/typings/dojo-core/dojo-core-2.0.0-pre.d.ts"/>
+///<reference path="../node_modules/dojo-core/typings/dojo-core/dojo-core-2.0.0-alpha.2.d.ts"/>
@kfranqueiro
kfranqueiro Feb 25, 2016 Member

Missing space after ///

@kfranqueiro kfranqueiro commented on the diff Feb 25, 2016
src/form.ts
@@ -15,7 +15,7 @@ export type FormValue = { [ key: string ]: any };
function findFirstEnabledIndex(select: HTMLSelectElement) {
const length = select.options.length;
for (let i = 0; i < length; i++) {
- if (!select.options[i].disabled) {
+ if (!(<HTMLOptionElement> select.options[i]).disabled) {
@kfranqueiro
kfranqueiro Feb 25, 2016 Member

I take it TS used to express HTMLSelectElement's options as an array or collection of HTMLOptionElements but 1.8 no longer does? Seems like a let-down...

@kitsonk
kitsonk Feb 25, 2016 Member

Actually it was an array of any, which is why you could have whatever you wanted as a property. In 1.8 it was more specific to Element. See Microsoft/TSJS-lib-generator#68

@kfranqueiro kfranqueiro and 1 other commented on an outdated diff Feb 25, 2016
"no-trailing-whitespace": true,
"no-unreachable": true,
"no-unused-expression": false,
- "no-unused-variable": true,
+ "no-unused-variable": false,
@kfranqueiro
kfranqueiro Feb 25, 2016 Member

Why is no-unused-variable being set to false? It's true in core...

@kitsonk
kitsonk Feb 25, 2016 Member

You are right. Problem in dojo2-package-template too.

@kitsonk kitsonk Correct tslint.json, fix linting issues
ebc643a
@codecov-io

Current coverage is 99.66%

Merging #33 into master will not affect coverage as of ebc643a

@@            master     #33   diff @@
======================================
  Files            6       6       
  Stmts          297     297       
  Branches        63      63       
  Methods         39      39       
======================================
  Hit            296     296       
  Partial          0       0       
  Missed           1       1       

Review entire Coverage Diff as of ebc643a

Powered by Codecov. Updated on successful CI builds.

@kitsonk kitsonk assigned vansimke and unassigned Tomdye Mar 2, 2016
@kitsonk
Member
kitsonk commented Mar 11, 2016

@vansimke have you reviewed this? If so, if you could add a comment to that effect.

@vansimke
Contributor

Sorry, haven't looked at it yet. Didn't realize this was a PR, so I didn't look for it. I'll take a look this morning.

@kitsonk kitsonk added this to the alpha.1 milestone Mar 11, 2016
@vansimke
Contributor

This looks good to me

@Tomdye Tomdye and 1 other commented on an outdated diff Mar 11, 2016
},
"devDependencies": {
"codecov.io": "0.1.6",
- "dojo-loader": "2.0.0-alpha.1",
+ "dojo-loader": ">2.0.0-alpha",
@Tomdye
Tomdye Mar 11, 2016 Member

-beta2

@kitsonk
kitsonk Mar 11, 2016 Member

this is still valid semver for beta.2

@kfranqueiro kfranqueiro referenced this pull request Mar 11, 2016
Closed

Upgrade to TypeScript 1.8.7 and add dojo-core dependency #39

0 of 2 tasks complete
@kitsonk kitsonk Change to TypeScript 1.8.7, lock down loader version
79e3b33
@kitsonk kitsonk modified the milestone: 2016.04, alpha.1 Apr 8, 2016
kitsonk added some commits Apr 11, 2016
@kitsonk kitsonk Merge branch 'master' into update-deps 8c49759
@kitsonk kitsonk Update deps
a584940
kitsonk added some commits Apr 11, 2016
@kitsonk kitsonk Migrate to SauceLabs
b3ee5a7
@kitsonk kitsonk Comment out Microsoft Edge testing
4735546
@kitsonk kitsonk merged commit 0ef88e7 into master Apr 11, 2016

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
jQuery Foundation CLA All authors have signed the CLA
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment