Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing: Navigation to default route should be syncronous #145

Closed
agubler opened this issue Oct 25, 2018 · 0 comments · Fixed by #148
Closed

Routing: Navigation to default route should be syncronous #145

agubler opened this issue Oct 25, 2018 · 0 comments · Fixed by #148
Labels

Comments

@agubler
Copy link
Member

@agubler agubler commented Oct 25, 2018

Bug

Navigating to a default route hands off responsibility to the history adapters which use the appropriate mechanism, when using the HashHistory this uses the hashchange event which is asynchronous.

When calling the router instance's setPath() explicitly we should synchronously process the change and guard against repeated (surplus) processing in the adaptors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant