Insertion order issue when performing a merge with an extra node #228

agubler · 2019-01-21T15:07:47Z

Bug

Nodes are merged in the wrong order when the client renders an extra node in between the HTML that is being merged against.

Code

<body>
    <div id="root">
        <div>
            <header></header>
            <footer></footer>
        </div>
    </div>
</body>

class MyWidget extends WidgetBase {
    render() {
        return v('div', [
            v('header', { id: 'header' }),
            v('div' { id: 'my-body' }),
            v('footer' { id: 'footer' })
        ]);
    }
}

// main.ts

const r = renderer(() => w(MyWidget, {});
r.mount({ domNode: document.getElementById('root')! });

Expected behavior:

Node Structure:

<body>
    <div id="root">
        <div>
            <header id="header"></header>
            <div id="my-body"></div>
            <footer id="footer"></footer>
        </div>
    </div>
</body>

Actual behavior:

Node structure:

<body>
    <div id="root">
        <div>
            <header id="header"></header>
            <footer id="footer"></footer>
            <div id="my-body"></div>
        </div>
    </div>
</body>

Package Version: 5.0.0-alpha.6

agubler mentioned this issue Jan 21, 2019

Determine the correct insertion position when rendering extra nodes on a merge #229

Merged

3 tasks

agubler closed this as completed in #229 Jan 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Insertion order issue when performing a merge with an extra node #228

Insertion order issue when performing a merge with an extra node #228

agubler commented Jan 21, 2019

Insertion order issue when performing a merge with an extra node #228

Insertion order issue when performing a merge with an extra node #228

Comments

agubler commented Jan 21, 2019