Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes working with base paths in state history #159

Merged
merged 5 commits into from Nov 22, 2018

Conversation

@agubler
Copy link
Member

commented Nov 7, 2018

Type: bug

The following has been addressed in the PR:

Description:

A few fixes for StateHistory history adapter:

  1. Add leading slash if missing to base path
  2. Default to window.__public_path__ if it exists
  3. Strip base on pushing the state
agubler added 4 commits Nov 7, 2018
@tomdye
tomdye approved these changes Nov 15, 2018
Copy link
Member

left a comment

Looks OK to me

@agubler agubler merged commit 54d27bb into dojo:master Nov 22, 2018

4 checks passed

codecov/patch 100% of diff hit (target 97.08%)
Details
codecov/project 97.09% (+0.01%) compared to c92c214
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.