Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Value doesn't update when setting the value of select in UI #170

Merged
merged 4 commits into from Nov 14, 2018

Conversation

@agubler
Copy link
Member

commented Nov 14, 2018

Type: bug

The following has been addressed in the PR:

Description:

The select value doesn't set because the dom value has already been updated, this means that because we run setValue before setting the select-value property the mechanism resets the value to the previous select value.

Make sure we set the select-value on the select node before we try and set the actual value.

agubler added 4 commits Nov 14, 2018
@tomdye
tomdye approved these changes Nov 14, 2018

@agubler agubler merged commit b78cd1d into dojo:master Nov 14, 2018

4 checks passed

codecov/patch 100% of diff hit (target 97.09%)
Details
codecov/project 97.09% (+0%) compared to 0019074
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
agubler added a commit to agubler/framework that referenced this pull request Nov 14, 2018
Bug: Value doesn't update when setting the value of select in UI (doj…
…o#170)

* failing unit test for changing select option in the ui

* set the select value before attempting to set the node value

* test for programmically updating the select value

* rename tests
agubler added a commit that referenced this pull request Nov 14, 2018
Bug: Value doesn't update when setting the value of select in UI (#170)…
… (#171)

* failing unit test for changing select option in the ui

* set the select value before attempting to set the node value

* test for programmically updating the select value

* rename tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.