Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate all has modules into single `has` module #182

Merged
merged 2 commits into from Nov 26, 2018

Conversation

@agubler
Copy link
Member

commented Nov 23, 2018

Type: feature

The following has been addressed in the PR:

Description:

Multiple has modules is a hangover from having multiple packages, that in order to avoid circular dependencies imported and re-exported the main has module in both core (now preset) and shim.

This PR moves all has functionality into the single main has module.

Related to #183

agubler added 2 commits Nov 14, 2018

@agubler agubler merged commit 19dfbd3 into dojo:master Nov 26, 2018

2 of 4 checks passed

codecov/patch 90.13% of diff hit (target 97.09%)
Details
codecov/project 97.09% (-0.01%) compared to 8bc723d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.