Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate all has modules into single has module #182

Merged
merged 2 commits into from Nov 26, 2018

Conversation

agubler
Copy link
Member

@agubler agubler commented Nov 23, 2018

Type: feature

The following has been addressed in the PR:

Description:

Multiple has modules is a hangover from having multiple packages, that in order to avoid circular dependencies imported and re-exported the main has module in both core (now preset) and shim.

This PR moves all has functionality into the single main has module.

Related to #183

@agubler agubler added breaking change Indicates the issue/pull request would result in a breaking change enhancement New feature or request next Issue/Pull Request for the next major version labels Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Indicates the issue/pull request would result in a breaking change enhancement New feature or request next Issue/Pull Request for the next major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants