Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include external polyfills in shim #184

Merged
merged 8 commits into from Nov 26, 2018

Conversation

@agubler
Copy link
Member

commented Nov 23, 2018

Type: feature

The following has been addressed in the PR:

Description:

  • Creates new shim modules for commonly used DOM ponyfills/polyfills in dojo/framework/shim.
  • Adds new build-elide has pragma for all external polyfill imports that will be elided at build time
  • Adds missing runtime has checks for all the new DOM APIs
  • Use shims through dojo/framework

Related to #183

agubler added 6 commits Nov 23, 2018

@agubler agubler force-pushed the agubler:add-polyfills-to-shim branch from fc7ea5e to 530d1dc Nov 26, 2018

@agubler agubler force-pushed the agubler:add-polyfills-to-shim branch from 9d1dbbd to 38445d3 Nov 26, 2018

@agubler agubler merged commit 68ccaa9 into dojo:master Nov 26, 2018

2 of 4 checks passed

codecov/patch 81.81% of diff hit (target 97.1%)
Details
codecov/project 97% (-0.11%) compared to 981a59e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.