Update type that causes 'Maximum call stack size exceeded' in 3.2.x#217
Merged
agubler merged 1 commit intodojo:masterfrom Jan 9, 2019
Merged
Update type that causes 'Maximum call stack size exceeded' in 3.2.x#217agubler merged 1 commit intodojo:masterfrom
agubler merged 1 commit intodojo:masterfrom
Conversation
matt-gadd
approved these changes
Jan 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
TypeScript 3.2.x starts throwing an error
RangeError: Maximum call stack size exceededdue to circular type reference used as a default type.This change updates the default type for the children nodes to
anyfor aDNodeto remove the use ofDNodeas a circular reference.Resolves #205