Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type that causes 'Maximum call stack size exceeded' in 3.2.x #217

Merged
merged 1 commit into from Jan 9, 2019

Conversation

@agubler
Copy link
Member

commented Jan 9, 2019

Type: bug

The following has been addressed in the PR:

Description:

TypeScript 3.2.x starts throwing an error RangeError: Maximum call stack size exceeded due to circular type reference used as a default type.

This change updates the default type for the children nodes to any for a DNode to remove the use of DNode as a circular reference.

Resolves #205

@agubler agubler merged commit 120396c into dojo:master Jan 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.