Skip to content

Assertion template enhancements - #412

Merged
agubler merged 14 commits into
dojo:masterfrom
agubler:assertion-template-enhancements
Jun 25, 2019
Merged

agubler merged 14 commits into
dojo:masterfrom
agubler:assertion-template-enhancements

Conversation

@agubler

@agubler agubler commented Jun 25, 2019 •

Copy link
Copy Markdown
Member

Type: feature

The following has been addressed in the PR:

Description:

Refines the assertion template API, providing additional helper APIs and changes one API to clarify the functionality.

Adds primitive for ignoring widgets during the assertion, useful for lists where there is no need to assert every single item.

Assertion Template Enhancements

API's changed:

replace -> replaceChildren

(this #247 (comment) came back to haunt me*)

*Actually @matt-gadd 😄

API's added:

replace
remove
setProperties
getProperties

New Assertion Template primitive:

Ignore

Supersedes #314 fixing the conflicts and unit tests on IE

@agubler
agubler merged commit b2cc67a into dojo:master Jun 25, 2019
@agubler agubler mentioned this pull request Jun 25, 2019
2 tasks done
@agubler agubler added area: testing Testing breaking change Indicates the issue/pull request would result in a breaking change labels Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: testing Testing breaking change Indicates the issue/pull request would result in a breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants