Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion template enhancements #412

Merged
merged 14 commits into from Jun 25, 2019

Conversation

@agubler
Copy link
Member

commented Jun 25, 2019

Type: feature

The following has been addressed in the PR:

Description:

Refines the assertion template API, providing additional helper APIs and changes one API to clarify the functionality.

Adds primitive for ignoring widgets during the assertion, useful for lists where there is no need to assert every single item.

Assertion Template Enhancements

API's changed:

replace -> replaceChildren

(this #247 (comment) came back to haunt me*)

*Actually @matt-gadd 馃槃

API's added:

replace
remove
setProperties
getProperties

New Assertion Template primitive:

Ignore

Supersedes #314 fixing the conflicts and unit tests on IE

matt-gadd and others added 13 commits Feb 18, 2019

@agubler agubler merged commit b2cc67a into dojo:master Jun 25, 2019

4 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@agubler agubler referenced this pull request Jun 25, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.