Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support factory functions for children replace on assertion templates #413

Merged
merged 4 commits into from Jun 25, 2019

Conversation

@agubler
Copy link
Member

commented Jun 25, 2019

Type: feature

The following has been addressed in the PR:

Description:

Extends the API for AssertionTemplate methods that work with children to support a function. This is the recommended way to work with these APIs to avoid issues with mutability.

Adds warning that the DNode[] API has been deprecated in favour of using a function () => DNode[].

Warning:

The array API (`children: DNode[]`) has been deprecated. Working with children should use a factory to avoid issues with mutation.

Resolves #333

agubler added 4 commits Jun 25, 2019

@agubler agubler merged commit 8d67d4b into dojo:master Jun 25, 2019

4 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.