Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support assertionTemplate operations on array root #470

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@aciccarello
Copy link
Contributor

commented Jul 26, 2019

Type: bug

Allows insert, remove, and replace operations on nodes in a root array of an assertion template.

Description:

Resolves #434

tests/testing/unit/assertionTemplate.tsx Outdated Show resolved Hide resolved

@aciccarello aciccarello requested a review from matt-gadd Aug 5, 2019

@aciccarello

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

@matt-gadd I've renamed that test

@aciccarello aciccarello merged commit 42c76bc into dojo:master Aug 5, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
licence/cla Contributor License Agreement is signed.
Details

@aciccarello aciccarello deleted the aciccarello:434/top-level-assertion-insert branch Aug 5, 2019

h.expect(insertionAssertion);
});

it('can remove a node', () => {

This comment has been minimized.

Copy link
@agubler

agubler Aug 8, 2019

Member

@aciccarello this test seems to be duplicated and is causing intern to get upset... the exact same test is two tests above, could have been accidentally left there when merging a conflicts perhaps?

This comment has been minimized.

Copy link
@aciccarello

aciccarello Aug 9, 2019

Author Contributor

@agubler As I look at that more, I think that was meant to be a replace node test. Sorry. 😞

@aciccarello aciccarello referenced this pull request Aug 9, 2019
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.