Provide live binding for properties and children with function-based widgets#564
Merged
agubler merged 6 commits intodojo:masterfrom Nov 4, 2019
Merged
Conversation
matt-gadd
approved these changes
Oct 23, 2019
rorticus
approved these changes
Oct 25, 2019
src/core/vdom.ts
Outdated
| if (widgetMeta) { | ||
| return widgetMeta.children; | ||
| } | ||
| return {}; |
agubler
added a commit
to agubler/framework
that referenced
this pull request
Nov 5, 2019
…widgets (dojo#564) * support tsx in vdom tests * failing unit test for live property binding * fix up failing unit tests * support live binding to children and properties * abstract widget args to function * use factory for middleware
3 tasks
agubler
added a commit
that referenced
this pull request
Nov 5, 2019
…widgets (#564) (#578) * Provide live binding for properties and children with function-based widgets (#564) * support tsx in vdom tests * failing unit test for live property binding * fix up failing unit tests * support live binding to children and properties * abstract widget args to function * use factory for middleware * default to empty array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
The
properties()function should provide a binding to the latest live property values, so whenproperties()is called in a callback it should provide the latest property value.Resolves #563