Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that diff property call backs are called immediately when registered #572

Merged
merged 3 commits into from Nov 5, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Nov 5, 2019

Type: bug

The following has been addressed in the PR:

Description:

diffProperty callbacks are not called for the first render which could mean that logic the user requires to run every render. This changes ensures that the diff properties are executed immediately when registered, subsequently they will be executed as they are currently.

@agubler agubler merged commit b8b4678 into dojo:master Nov 5, 2019
4 checks passed
agubler added a commit to agubler/framework that referenced this issue Nov 5, 2019
…stered (dojo#572)

* failing unit test for diff property on the first render

* Call diff properties immediately when they are registered

* prettier
agubler added a commit that referenced this issue Nov 5, 2019
…stered (#572) (#573)

* failing unit test for diff property on the first render

* Call diff properties immediately when they are registered

* prettier
agubler added a commit to agubler/framework that referenced this issue Nov 5, 2019
agubler added a commit to agubler/framework that referenced this issue Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants