Ensure that diff property call backs are called immediately when registered#572
Merged
agubler merged 3 commits intodojo:masterfrom Nov 5, 2019
Merged
Ensure that diff property call backs are called immediately when registered#572agubler merged 3 commits intodojo:masterfrom
agubler merged 3 commits intodojo:masterfrom
Conversation
matt-gadd
approved these changes
Nov 5, 2019
agubler
added a commit
to agubler/framework
that referenced
this pull request
Nov 5, 2019
…stered (dojo#572) * failing unit test for diff property on the first render * Call diff properties immediately when they are registered * prettier
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
diffPropertycallbacks are not called for the first render which could mean that logic the user requires to run every render. This changes ensures that the diff properties are executed immediately when registered, subsequently they will be executed as they are currently.