Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state in focus middleware #575

Merged
merged 2 commits into from Nov 5, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Nov 5, 2019

Type: bug

The following has been addressed in the PR:

Description:

The state in the focus middleware was incorrectly getting the current value from the cache, but setting it in the icache. This means that after the first focus call, shouldFocus would always be false. This highlights just one of the issues with mixing icache and cache.

This changes the logic to use icache for everything except the active element which is simply kept in the scope of the middlware.

@agubler agubler force-pushed the fix-state-in-focus-middleware branch from b13a953 to 8fcbbae Compare Nov 5, 2019
@agubler agubler merged commit 8e6d077 into dojo:master Nov 5, 2019
4 checks passed
agubler added a commit to agubler/framework that referenced this issue Nov 5, 2019
* failing unit test

* do not mix cache and icache
@agubler agubler mentioned this pull request Nov 5, 2019
3 tasks
agubler added a commit that referenced this issue Nov 5, 2019
* failing unit test

* do not mix cache and icache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants