Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure assertion template children are immutable #587

Merged
merged 3 commits into from Nov 14, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Nov 14, 2019

Type: bug

The following has been addressed in the PR:

Description:

Ensure that children set on assertion templates are always immutable.

Resolves #586

tomdye
tomdye approved these changes Nov 14, 2019
@agubler agubler merged commit a777de5 into dojo:master Nov 14, 2019
4 checks passed
agubler added a commit to agubler/framework that referenced this issue Dec 17, 2019
* Failing unit test for mutable children

* package-lock

* Ensure children are not able to be mutated when using the children and sibling apis
agubler added a commit that referenced this issue Dec 18, 2019
* Failing unit test for mutable children

* package-lock

* Ensure children are not able to be mutated when using the children and sibling apis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants