Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure mixins properties are inferred when using tsx #594

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Dec 3, 2019

Type: bug

The following has been addressed in the PR:

Description:

Fix property interference when using a widget with mixins via tsx.

Resolves #592

@agubler agubler changed the title Ensure mixins ensure properties are inferred when using tsx Ensure mixins properties are inferred when using tsx Dec 3, 2019
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 3, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 979912d:

Sandbox Source
dojo-codesandbox-template Configuration

@agubler agubler force-pushed the infer-mixin-properties branch from 1a223de to 86e9498 Compare December 3, 2019 12:22
@agubler agubler merged commit 5ca2288 into dojo:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using theme and classes on themed widgets throws a type error unless it extends ThemedProperties
2 participants