Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run comparators when using expect with an actual render argument #602

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

tomdye
Copy link
Member

@tomdye tomdye commented Dec 9, 2019

Type: bug / feature

The following has been addressed in the PR:

Description:

Runs compares for actual result on each call to expect

Resolves #600

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2f4f200:

Sandbox Source
confident-sky-if2ef Configuration

@tomdye tomdye changed the title Run custom comparators for render prop results Run comparators when using expect with an actual render property Dec 9, 2019
@matt-gadd matt-gadd changed the title Run comparators when using expect with an actual render property Run comparators when using expect with an actual render argument Dec 9, 2019
@tomdye tomdye merged commit ed33839 into dojo:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Comparators are not ran when passing an actual render function to expect
3 participants