Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type i18n format function using the passed bundle message keys #610

Merged
merged 1 commit into from Jan 8, 2020

Conversation

JamesLMilner
Copy link
Contributor

@JamesLMilner JamesLMilner commented Dec 20, 2019

Type: feature

The following has been addressed in the PR:

Description:

This PR prevents i18n middleware users from passing keys that aren't part of the bundle messages to the format function.

Resolves #591

i18nformat

@JamesLMilner JamesLMilner requested a review from agubler Dec 20, 2019
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 20, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f06955:

Sandbox Source
autumn-fog-idbmo Configuration

agubler
agubler approved these changes Jan 7, 2020
@JamesLMilner JamesLMilner merged commit cb34257 into dojo:master Jan 8, 2020
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants