Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cache middleware and add optional flag to skip invalidation with the icache #618

Merged
merged 7 commits into from Dec 23, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Dec 21, 2019

Type: feature

The following has been addressed in the PR:

Description:

Add optional parameter to the icache middleware set APIs to skip invalidation. Invert the dependency between the cache and icache so the cache can be deprecated. Includes a deprecation message on use of the cache middleware

Updates the documentation to reflect the changes made.

Resolves #616
Resolves #617

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 21, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e185720:

Sandbox Source
pedantic-goldstine-1y1cs Configuration

@agubler agubler merged commit 49968a3 into dojo:master Dec 23, 2019
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants