Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure childDomWrapperId is available to insert nodes in the correct order #642

Merged
merged 2 commits into from Jan 13, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Jan 10, 2020

Type: bug

The following has been addressed in the PR:

Description:

If the childDomWrapperId is not available when trying to find the correct node to insert before, try to find the wrapper id again.

Resolves #641

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4fa142d:

Sandbox Source
unruffled-chatelet-pgs04 Configuration

@agubler agubler merged commit 5cc936d into dojo:master Jan 13, 2020
5 checks passed
agubler added a commit to agubler/framework that referenced this issue Jan 13, 2020
…order (dojo#642)

* Failing unit test for issue 641

* Ensure childDomWrapperId is available to insert nodes in the correct order
agubler added a commit that referenced this issue Jan 16, 2020
…rect order (#644)

* Ensure childDomWrapperId is available to insert nodes in the correct order (#642)

* Failing unit test for issue 641

* Ensure childDomWrapperId is available to insert nodes in the correct order

* package-lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants