Ensure childDomWrapperId is available to insert nodes in the correct order#642
Merged
agubler merged 2 commits intodojo:masterfrom Jan 13, 2020
Merged
Ensure childDomWrapperId is available to insert nodes in the correct order#642agubler merged 2 commits intodojo:masterfrom
agubler merged 2 commits intodojo:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4fa142d:
|
rorticus
approved these changes
Jan 10, 2020
agubler
added a commit
to agubler/framework
that referenced
this pull request
Jan 13, 2020
…order (dojo#642) * Failing unit test for issue 641 * Ensure childDomWrapperId is available to insert nodes in the correct order
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
If the
childDomWrapperIdis not available when trying to find the correct node to insert before, try to find the wrapper id again.Resolves #641